Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add times, dates and stations datasets #1

Merged
merged 23 commits into from
Oct 26, 2023

Conversation

saattrupdan
Copy link
Collaborator

@saattrupdan saattrupdan commented Oct 24, 2023

This PR adds the following:

  1. A dates dataset, with day, month and year
  2. A times dataset, with hour and minute, as well as expressions such as "kvart i fire"
  3. A script that interleaves them according to given sampling probabilities
  4. Setup of docker - running make docker will build the dataset in the data folder.
  5. Updates the readme with a quick start

@saattrupdan saattrupdan self-assigned this Oct 24, 2023
Copy link
Collaborator

@AJDERS AJDERS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, minor change

src/tts_text/dates.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AJDERS AJDERS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saattrupdan saattrupdan merged commit 44122d0 into main Oct 26, 2023
2 checks passed
@saattrupdan saattrupdan deleted the feat/add-times-dates-stations-datasets branch October 26, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants